yusufipek/OpenFrame
1
0
Fork 0
mirror of https://github.com/yusufipk/OpenFrame.git synced 2026-09-11 17:46:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #38 from yusufipk/fix/public-project-hides-workspace-admin-actions

Browse Source 
fix(auth): keep workspace admin permissions on public projects
This commit is contained in:
Yusuf İpek
2026-07-25 13:18:38 +03:00
committed by GitHub
parent 58910a5f5a 60b2bc7369
commit 322395551a
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/auth.ts
+7 -3
View File
@@ -281,9 +281,13 @@ export async function checkProjectAccess(
const isProjectMember = !!projectMember; const isProjectMember = !!projectMember;
const isProjectAdmin = projectMember?.role === ProjectMemberRole.ADMIN; const isProjectAdmin = projectMember?.role === ProjectMemberRole.ADMIN;
const needsWorkspaceForAccess = !!userId && !isOwner && !isProjectMember && !isPublic; // The workspace role decides `canEdit`/`isWorkspaceMember`, not just whether the viewer
const needsWorkspaceForActions = !!userId && !isOwner && intent !== 'view'; // gets in at all, so it has to be resolved for every signed-in non-owner. Skipping it
const shouldLoadWorkspaceRole = needsWorkspaceForAccess || needsWorkspaceForActions; // once access was already granted some other way (public project, or an existing project
// membership) silently downgraded workspace admins to read-only on `intent: 'view'` —
// the intent pages and GET routes use to decide which actions to render.
// Owners pass every check on their own; resolve their role only when they mutate.
const shouldLoadWorkspaceRole = !!userId && (!isOwner || intent !== 'view');
// Check workspace membership/role // Check workspace membership/role
let workspaceRole: WorkspaceMemberRole | 'OWNER' | null = null; let workspaceRole: WorkspaceMemberRole | 'OWNER' | null = null;