Merge pull request #47 from yusufipk/fix/bunny-orphan-url-reference

fix(scripts): count a Bunny id referenced by url, not only by column

scripts/bunny-orphan-cleanup.ts

@@ -166,32 +166,53 @@ function chunk<T>(items: T[], size: number): T[][] {
   return out;
 }
 
+/**
+ * Every Bunny id the database still points at.
+ *
+ * A Bunny id is stored in two places per row, and both are checked. `VideoVersion.videoId`
+ * and `VideoAsset.providerVideoId` hold the guid on its own, while `originalUrl` and
+ * `sourceUrl` embed the same guid inside
+ * `https://iframe.mediadelivery.net/embed/<library>/<guid>`. They are written together, so
+ * they normally agree, but this decides what gets deleted: a row whose id column was left
+ * empty or drifted while its url still carried the guid would make a live video look
+ * orphaned. Reading both makes disagreement harmless rather than destructive.
+ */
 async function findReferencedVideoIds(videoIds: string[]): Promise<Set<string>> {
   const referenced = new Set<string>();
 
   for (const group of chunk(videoIds, CHUNK_SIZE)) {
     const [versionRows, assetRows] = await Promise.all([
       db.videoVersion.findMany({
-        where: {
+        where: { providerId: 'bunny' },
-          providerId: 'bunny',
+        select: { videoId: true, originalUrl: true },
-          videoId: { in: group },
-        },
-        select: { videoId: true },
       }),
       db.videoAsset.findMany({
-        where: {
+        where: { provider: 'BUNNY' },
-          provider: 'BUNNY',
+        select: { providerVideoId: true, sourceUrl: true },
-          providerVideoId: { in: group },
-        },
-        select: { providerVideoId: true },
       }),
     ]);
-    versionRows.forEach((row) => {
+
-      if (row.videoId) referenced.add(row.videoId);
+    // Every Bunny row is read rather than filtered by id, because the url has to be
-    });
+    // searched for a guid it merely contains. There are as many of these rows as there
-    assetRows.forEach((row) => {
+    // are Bunny videos in the product, so this is one small scan instead of one LIKE per
-      if (row.providerVideoId) referenced.add(row.providerVideoId);
+    // candidate id.
-    });
+    const ids = new Set(group);
+    const urls: string[] = [];
+
+    for (const row of versionRows) {
+      if (row.videoId && ids.has(row.videoId)) referenced.add(row.videoId);
+      if (row.originalUrl) urls.push(row.originalUrl);
+    }
+    for (const row of assetRows) {
+      if (row.providerVideoId && ids.has(row.providerVideoId)) referenced.add(row.providerVideoId);
+      if (row.sourceUrl) urls.push(row.sourceUrl);
+    }
+
+    for (const url of urls) {
+      for (const id of group) {
+        if (!referenced.has(id) && url.includes(id)) referenced.add(id);
+      }
+    }
   }
 
   return referenced;