mirror of
https://github.com/yusufipk/OpenFrame.git
synced 2026-09-11 09:36:08 +00:00
fix(player): label only 16x as silent in the speed picker
The "no audio" note was attached to everything past 4x on a guess about where the browsers stop pitch-correcting. Playing the ladder through confirms audio survives 6x and 8x; 16x, the rate Chrome and Firefox clamp to, is the only silent one. Move the threshold up so the two fast rates that do carry sound stop advertising otherwise.
This commit is contained in:
@@ -103,10 +103,11 @@ export function timeFromClientX(
|
||||
export const YOUTUBE_SPEED_OPTIONS = [0.25, 0.5, 0.75, 1, 1.25, 1.5, 1.75, 2];
|
||||
export const NATIVE_SPEED_OPTIONS = [0.25, 0.5, 0.75, 1, 1.25, 1.5, 1.75, 2, 2.5, 3, 4, 6, 8, 16];
|
||||
|
||||
// Past 4x the browsers stop pitch-correcting and drop the audio track entirely.
|
||||
// The video still plays, so the fast rates are worth offering, but the picker
|
||||
// says so rather than letting a silent 8x read as a broken file.
|
||||
export const SILENT_ABOVE_SPEED = 4;
|
||||
// The browsers keep the audio track well past the point where they stop
|
||||
// pitch-correcting: playback is still audible at 8x, and only the 16x clamp is
|
||||
// silent. The video plays either way, so the rate stays on the ladder and the
|
||||
// picker labels it rather than letting a silent 16x read as a broken file.
|
||||
export const SILENT_ABOVE_SPEED = 8;
|
||||
|
||||
export function getSpeedOptionsForProvider(providerId: string | null | undefined): number[] {
|
||||
return providerId === 'youtube' ? YOUTUBE_SPEED_OPTIONS : NATIVE_SPEED_OPTIONS;
|
||||
|
||||
Reference in New Issue
Block a user