mirror of
https://github.com/yusufipk/OpenFrame.git
synced 2026-09-11 09:36:08 +00:00
A reservation id was never a secret and could not have been one. An upload token is base64url(payload) followed by its signature, so a client can read every claim out of its own token, and the two R2 init routes hand their reservation ids to the client outright. The asset route takes a reservation id from the request body and deleted it on the strength of that id and the billed user alone, and every hold an account owns is billed to the same user. So a caller could start a Bunny upload, read the id out of the token they were just given, quote it while attaching a one byte image or even a bare YouTube link, and have the quota handed back while the upload carried on. Repeat and a trial worth three gigabytes uploads as much as it likes for as long as Bunny takes to report a figure of its own. Signing the id rather than handing it over bought nothing, because signing is not hiding. A hold now records what it was opened for and is only ever consumed by that flow, so naming one is no longer enough to drop it. Guests hold against the workspace owner's quota rather than their own and had no way to give it back: the release was gated on being signed in. Declaring a size and walking away cost the guest nothing and cost the owner their whole remaining allowance for two hours. The guest grant now carries the reservation and the declared size, bound to the Bunny video as well as to ours, so cancelling gives the quota back and costs them the upload it stood for. What a guest can hold without cancelling lapses in half an hour rather than two hours. The in-transaction fallback check counted the account's Bunny storage as zero on a Bunny upload, because the figure was only prefetched for R2 providers and that branch was unreachable for Bunny until this PR made it reachable. On an account whose storage is all Bunny that was a check that could not fail. It is prefetched for every provider that can reach the fallback now.
268 lines
9.7 KiB
TypeScript
268 lines
9.7 KiB
TypeScript
import type { NextResponse } from 'next/server';
|
|
import { db } from '@/lib/db';
|
|
import { apiErrors } from '@/lib/api-response';
|
|
import { isStripeFeatureEnabled } from '@/lib/feature-flags';
|
|
import { getCachedUserBunnyStorage } from '@/lib/admin-stats';
|
|
import { isPaidTier } from '@/lib/billing';
|
|
import { getStorageLimitBytes } from '@/lib/trial-limits';
|
|
|
|
// 200 GB expressed in bytes
|
|
export const PLAN_STORAGE_LIMIT_BYTES = BigInt(200) * BigInt(1024) * BigInt(1024) * BigInt(1024);
|
|
|
|
/**
|
|
* The ceiling this particular account is held to.
|
|
*
|
|
* A cardless trial gets a much smaller one: it is the only thing standing between
|
|
* a throwaway signup and 200 GB of our storage. Reads the two billing columns
|
|
* directly rather than taking a flag from the caller, so no upload route can
|
|
* forget to pass it.
|
|
*/
|
|
export async function getStorageLimitForUser(userId: string): Promise<bigint> {
|
|
const user = await db.user.findUnique({
|
|
where: { id: userId },
|
|
select: { subscriptionStatus: true, stripeCurrentPeriodEnd: true },
|
|
});
|
|
|
|
return getStorageLimitBytes(user ? isPaidTier(user) : false, PLAN_STORAGE_LIMIT_BYTES);
|
|
}
|
|
|
|
// TTL for upload reservations: 30 minutes is enough for R2 image/audio uploads
|
|
const RESERVATION_TTL_MS = 30 * 60 * 1000;
|
|
|
|
/**
|
|
* What a hold was opened for.
|
|
*
|
|
* A reservation is only ever consumed by the flow that opened it, and the
|
|
* finalize routes match on this as well as on the id. Without it, naming a
|
|
* reservation would be enough to drop it: the asset route takes a reservation id
|
|
* from the request body, and every hold an account owns is billed to the same
|
|
* user, so an image being attached could quietly release a video upload that was
|
|
* still in flight. The ids are not secret. Two of them are handed to the client
|
|
* outright, and the rest ride inside signed-but-readable token payloads.
|
|
*/
|
|
export const UPLOAD_RESERVATION_PURPOSES = {
|
|
/** A comment attachment or standalone image going to R2. */
|
|
IMAGE: 'IMAGE',
|
|
/** A voice note going to R2. */
|
|
AUDIO: 'AUDIO',
|
|
/** Image and voice attachments weighed together when a comment is posted. */
|
|
ATTACHMENT: 'ATTACHMENT',
|
|
/** A presigned direct upload to our own S3-compatible storage. */
|
|
R2_VIDEO: 'R2_VIDEO',
|
|
/** A direct upload to Bunny, where the bytes never pass through us. */
|
|
BUNNY: 'BUNNY',
|
|
} as const;
|
|
|
|
export type UploadReservationPurpose =
|
|
(typeof UPLOAD_RESERVATION_PURPOSES)[keyof typeof UPLOAD_RESERVATION_PURPOSES];
|
|
|
|
// Sentinel error thrown inside a Prisma transaction to signal quota exceeded
|
|
class QuotaExceededError extends Error {}
|
|
|
|
/**
|
|
* Returns total bytes used by a given billed user across R2 (image + audio),
|
|
* Bunny Stream, and any active (non-expired) upload reservations.
|
|
* Uses the cached Bunny stats (10-min TTL) to avoid calling the Bunny API on
|
|
* every upload.
|
|
*/
|
|
export async function getUserTotalStorageBytes(userId: string): Promise<bigint> {
|
|
const [r2AssetRows, r2VideoRows, bunnyByUser, reservationRows] = await Promise.all([
|
|
db.$queryRaw<[{ total: bigint }]>`
|
|
SELECT COALESCE(SUM(size_bytes), 0)::bigint AS total
|
|
FROM video_assets
|
|
WHERE "billedUserId" = ${userId}
|
|
AND provider IN ('R2_IMAGE', 'R2_AUDIO', 'R2_VIDEO')
|
|
`,
|
|
db.$queryRaw<[{ total: bigint }]>`
|
|
SELECT COALESCE(SUM(vv.size_bytes), 0)::bigint AS total
|
|
FROM video_versions vv
|
|
INNER JOIN videos v ON v.id = vv."videoParentId"
|
|
INNER JOIN projects p ON p.id = v."projectId"
|
|
INNER JOIN workspaces w ON w.id = p."workspaceId"
|
|
WHERE w."ownerId" = ${userId}
|
|
AND vv."providerId" = 'r2'
|
|
`,
|
|
getCachedUserBunnyStorage(),
|
|
db.$queryRaw<[{ total: bigint }]>`
|
|
SELECT COALESCE(SUM("sizeBytes"), 0)::bigint AS total
|
|
FROM upload_reservations
|
|
WHERE "billedUserId" = ${userId}
|
|
AND "expiresAt" > NOW()
|
|
`,
|
|
]);
|
|
|
|
const r2AssetBytes = r2AssetRows[0]?.total ?? BigInt(0);
|
|
const r2VideoBytes = r2VideoRows[0]?.total ?? BigInt(0);
|
|
const bunnyBytes = BigInt(bunnyByUser[userId] ?? 0);
|
|
const reservedBytes = reservationRows[0]?.total ?? BigInt(0);
|
|
|
|
return r2AssetBytes + r2VideoBytes + bunnyBytes + reservedBytes;
|
|
}
|
|
|
|
/**
|
|
* Returns storage usage info for a user in a UI-friendly shape.
|
|
*/
|
|
export async function getUserStorageInfo(userId: string): Promise<{
|
|
usedBytes: bigint;
|
|
limitBytes: bigint;
|
|
percentage: number;
|
|
}> {
|
|
const [usedBytes, limitBytes] = await Promise.all([
|
|
getUserTotalStorageBytes(userId),
|
|
getStorageLimitForUser(userId),
|
|
]);
|
|
const percentage =
|
|
limitBytes > BigInt(0)
|
|
? Math.min(100, Number((usedBytes * BigInt(10000)) / limitBytes) / 100)
|
|
: 0;
|
|
|
|
return { usedBytes, limitBytes, percentage };
|
|
}
|
|
|
|
/**
|
|
* Checks whether the user can upload `incomingSizeBytes` more data.
|
|
*
|
|
* Returns a 507 response if the quota would be exceeded, or `null` if the
|
|
* upload is allowed. When Stripe is disabled the check is always skipped so
|
|
* self-hosted instances without billing still work.
|
|
*
|
|
* Uses `>=` so a user at exactly the limit cannot initiate new uploads.
|
|
*/
|
|
export async function enforceStorageQuota(
|
|
userId: string,
|
|
incomingSizeBytes: bigint
|
|
): Promise<NextResponse | null> {
|
|
if (!isStripeFeatureEnabled()) {
|
|
return null;
|
|
}
|
|
|
|
const [usedBytes, limitBytes] = await Promise.all([
|
|
getUserTotalStorageBytes(userId),
|
|
getStorageLimitForUser(userId),
|
|
]);
|
|
|
|
if (usedBytes + incomingSizeBytes >= limitBytes) {
|
|
return apiErrors.storageExceeded() as NextResponse;
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* Atomically checks the quota and records an in-flight upload reservation.
|
|
*
|
|
* Uses a PostgreSQL advisory transaction lock (per user) so concurrent callers
|
|
* are serialised: the second request sees the first reservation in the sum and
|
|
* cannot double-book the same headroom.
|
|
*
|
|
* Returns `{ reservationId }` on success or `{ error }` (a 507 NextResponse)
|
|
* when the quota would be exceeded. Call `releaseStorageReservation` to delete
|
|
* the reservation once the paired asset is committed (or if the upload fails).
|
|
*
|
|
* When Stripe is disabled the check is skipped and `reservationId` is `null`.
|
|
*/
|
|
export async function reserveStorageQuota(
|
|
userId: string,
|
|
incomingSizeBytes: bigint,
|
|
purpose: UploadReservationPurpose,
|
|
reservationTtlMs: number = RESERVATION_TTL_MS
|
|
): Promise<{ reservationId: string | null } | { error: NextResponse }> {
|
|
if (!isStripeFeatureEnabled()) {
|
|
return { reservationId: null };
|
|
}
|
|
|
|
const expiresAt = new Date(Date.now() + reservationTtlMs);
|
|
|
|
// Fetch Bunny storage and the account's ceiling BEFORE entering the transaction,
|
|
// to avoid holding the advisory lock during a potentially slow/failing HTTP call
|
|
// on cache miss or an extra round trip to Postgres.
|
|
const [bunnyData, limitBytes] = await Promise.all([
|
|
getCachedUserBunnyStorage(),
|
|
getStorageLimitForUser(userId),
|
|
]);
|
|
const bunnyBytes = BigInt(bunnyData[userId] ?? 0);
|
|
|
|
try {
|
|
const reservationId = await db.$transaction(async (tx) => {
|
|
// Serialise quota checks for this user via a per-user advisory lock.
|
|
// Combine two 32-bit hashtext() halves into a single 64-bit bigint to
|
|
// eliminate the 32-bit hash-space collision risk of plain hashtext().
|
|
// Use $executeRaw — the function returns void which $queryRaw cannot deserialize.
|
|
await tx.$executeRaw`
|
|
SELECT pg_advisory_xact_lock(
|
|
('x' || left(md5(${userId}), 16))::bit(64)::bigint
|
|
)
|
|
`;
|
|
|
|
// Read committed R2 storage under the lock
|
|
const [r2AssetRow] = await tx.$queryRaw<[{ total: bigint }]>`
|
|
SELECT COALESCE(SUM(size_bytes), 0)::bigint AS total
|
|
FROM video_assets
|
|
WHERE "billedUserId" = ${userId}
|
|
AND provider IN ('R2_IMAGE', 'R2_AUDIO', 'R2_VIDEO')
|
|
`;
|
|
const [r2VideoRow] = await tx.$queryRaw<[{ total: bigint }]>`
|
|
SELECT COALESCE(SUM(vv.size_bytes), 0)::bigint AS total
|
|
FROM video_versions vv
|
|
INNER JOIN videos v ON v.id = vv."videoParentId"
|
|
INNER JOIN projects p ON p.id = v."projectId"
|
|
INNER JOIN workspaces w ON w.id = p."workspaceId"
|
|
WHERE w."ownerId" = ${userId}
|
|
AND vv."providerId" = 'r2'
|
|
`;
|
|
const r2Bytes = (r2AssetRow?.total ?? BigInt(0)) + (r2VideoRow?.total ?? BigInt(0));
|
|
|
|
// Read active (non-expired) reservations under the same lock
|
|
const [resRow] = await tx.$queryRaw<[{ total: bigint }]>`
|
|
SELECT COALESCE(SUM("sizeBytes"), 0)::bigint AS total
|
|
FROM upload_reservations
|
|
WHERE "billedUserId" = ${userId}
|
|
AND "expiresAt" > NOW()
|
|
`;
|
|
const reservedBytes = resRow?.total ?? BigInt(0);
|
|
|
|
const totalUsed = r2Bytes + reservedBytes + bunnyBytes;
|
|
if (totalUsed + incomingSizeBytes >= limitBytes) {
|
|
throw new QuotaExceededError();
|
|
}
|
|
|
|
const reservation = await tx.uploadReservation.create({
|
|
data: { billedUserId: userId, sizeBytes: incomingSizeBytes, expiresAt, purpose },
|
|
select: { id: true },
|
|
});
|
|
|
|
return reservation.id;
|
|
});
|
|
|
|
return { reservationId };
|
|
} catch (e) {
|
|
if (e instanceof QuotaExceededError) {
|
|
return { error: apiErrors.storageExceeded() as NextResponse };
|
|
}
|
|
throw e;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Deletes an upload reservation created by `reserveStorageQuota`.
|
|
* Safe to call with `null` (no-op) for flows where billing is disabled.
|
|
*
|
|
* Pass the purpose wherever the caller knows it. A release that names only an id
|
|
* will delete a hold opened for something else, which is the same hole the
|
|
* purpose column exists to close.
|
|
*/
|
|
export async function releaseStorageReservation(
|
|
reservationId: string | null,
|
|
billedUserId?: string | null,
|
|
purpose?: UploadReservationPurpose
|
|
): Promise<void> {
|
|
if (!reservationId) return;
|
|
await db.uploadReservation.deleteMany({
|
|
where: {
|
|
id: reservationId,
|
|
...(billedUserId ? { billedUserId } : {}),
|
|
...(purpose ? { purpose } : {}),
|
|
},
|
|
});
|
|
}
|