Files
OpenFrame/tests/setup/api.ts
T
yusufipk 0187db5dc7 test: close the coverage gaps the first round left
Second pass over the suite, driven by the inventory in the gaps document. Nine
agents wrote suites in parallel against private databases, then a tenth read all
of it adversarially and five of its findings were fixed.

  unit + component  2076 -> 2079 (+888 over the round)
  api                647 -> 1015
  e2e                 18 -> 29

What was closed:

- lib/route-access.ts, the page-level authorization layer, went from zero tests
  to 48. Every API route was guarded and none of the pages were.
- The five media proxy routes now have a real 2xx beside every 403. The blocker
  was the positive control, solved by stubbing r2Client.send() and leaving
  lib/r2-media-proxy.ts itself real.
- Every remaining server-side lib module: invitations, email verification, the
  upload tokens, the logger, request origin, the whole R2 and Bunny lifecycle,
  notifications and admin stats.
- Six video-page hooks, and the chunking arithmetic extracted out of
  lib/client/r2-video-upload.ts as a pure module.
- Five end-to-end flows: workspace members, bulk operations, the admin area,
  player interaction and failure recovery.

Three things about the harness itself turned out to be wrong:

- Two @/lib/r2 stubs in tests/setup/api.ts had the wrong return shape, so every
  route reaching finalizeR2VideoUpload silently took the "not a valid video"
  branch and no test noticed.
- The auth matrix asserted only "not 2xx", which two entries satisfied without
  their guard existing. It now requires 401 or 403, which makes both
  load-bearing, and all 60 routes pass the stricter form.
- Both admin API routes had no positive control anywhere: replacing their guard
  with an unconditional refusal left the entire suite green. Found by the
  adversarial review, now covered.

Process:

- bun run test:mutation runs StrykerJS over the authorization and validation
  modules. Diagnostic, not a gate, weekly in CI rather than on a push.
- playwright.config.ts gains an opt-in webkit project for the player spec.
- AGENTS.md now requires a batch of new tests to be reviewed by somebody who
  did not write them.

Only two production files change, both deliberate: lib/auth.ts loses a verbatim
copy of its own permission formulas, and lib/client/r2-video-upload.ts calls the
extracted arithmetic. No behaviour change in either.
2026-07-26 13:25:11 +07:00

218 lines
10 KiB
TypeScript

// Per-file setup for the `api` Vitest project.
//
// Runs before each test file is imported, which is what makes the vi.mock()
// registrations below reliable: they are in place before any test file pulls
// `@/lib/auth` or `nodemailer` into its module graph. Putting them in a helper
// that a test file imports would make the registration order depend on the
// order of that file's import statements.
//
// See TESTING.md section 5.
// MUST stay the first import. tests/helpers/env.ts loads .env.test on
// evaluation, and `@/lib/db` (reached below through tests/helpers/db.ts) reads
// process.env.DATABASE_URL once at module load and memoizes the pg pool on
// globalThis. ESM evaluates dependencies in import order, so anything that moves
// above this line points the whole suite at the wrong database.
import '../helpers/env';
import { afterEach, beforeAll, beforeEach, vi } from 'vitest';
import { resetDb } from '../helpers/db';
import { resetSentMail } from '../helpers/mail';
// lib/db.ts registers a SIGINT and a SIGTERM listener at module scope. With one
// module registry per test file that is two listeners per file, which trips
// Node's default limit of 10 and floods the output with
// MaxListenersExceededWarning. Lifting the cap is enough; lib/db.ts is
// production code and is left alone.
process.setMaxListeners(0);
// ---------------------------------------------------------------------------
// Session
// ---------------------------------------------------------------------------
// Partial mock: only `auth` is replaced. checkProjectAccess(),
// checkWorkspaceAccess() and computeProjectAccess() keep their real
// implementations and keep querying the real test database, because they are the
// subject of these tests rather than a dependency of them.
vi.mock('@/lib/auth', async (importOriginal) => {
const actual = await importOriginal<typeof import('@/lib/auth')>();
return { ...actual, auth: vi.fn() };
});
// ---------------------------------------------------------------------------
// Next.js cache primitives
// ---------------------------------------------------------------------------
// revalidatePath() has no request scope to work with outside a server render,
// and unstable_cache() would wrap the Bunny/R2 stat helpers in a cache that has
// no incremental-cache handler behind it. Identity is the right stand-in for
// both.
vi.mock('next/cache', () => ({
revalidatePath: vi.fn(),
revalidateTag: vi.fn(),
unstable_cache: <T extends (...args: never[]) => unknown>(fn: T) => fn,
unstable_noStore: vi.fn(),
}));
// ---------------------------------------------------------------------------
// Object storage
// ---------------------------------------------------------------------------
// Presigners return deterministic fake URLs so a test can assert on the object
// key that a route chose, which is the part that actually matters. Nothing here
// speaks S3.
vi.mock('@/lib/r2', async (importOriginal) => {
const actual = await importOriginal<typeof import('@/lib/r2')>();
return {
...actual,
createPresignedVideoPutUrl: vi.fn(async (key: string) => `https://r2.test/put/${key}`),
createPresignedImagePutUrl: vi.fn(async (key: string) => `https://r2.test/put/${key}`),
createPresignedUploadPartUrl: vi.fn(
async (key: string, uploadId: string, partNumber: number) =>
`https://r2.test/part/${key}?uploadId=${uploadId}&partNumber=${partNumber}`
),
createMultipartVideoUpload: vi.fn(async () => 'test-multipart-upload-id'),
completeMultipartVideoUpload: vi.fn(async () => undefined),
abortMultipartVideoUpload: vi.fn(async () => undefined),
uploadAudio: vi.fn(async (key: string) => `https://r2.test/object/${key}`),
deleteVideoObject: vi.fn(async () => undefined),
deleteR2Object: vi.fn(async () => undefined),
// These two must match the real return shapes exactly, and for a while they
// did not. `headVideoObject` really answers `contentLength: bigint`, and
// `readVideoObjectBytes` really answers `Uint8Array | null`, not an object
// wrapping one.
//
// The wrong shapes were not inert. `finalizeR2VideoUpload` passes the head
// result straight through as `sizeBytes`, so a `number` reached a BigInt
// column and only survived on Prisma's coercion. Worse, the old
// `readVideoObjectBytes` stub returned a truthy object with no `.length`,
// so `hasKnownVideoMagicBytes()` saw zero bytes and every route reaching
// finalize took the "Uploaded file is not a valid video" branch, cancelled
// the session and deleted both objects. Nothing caught it because no test
// drove that path to success until tests/api/lib-r2-video-finalize.test.ts.
// Both keep the guards the real functions apply before they ever speak to
// S3: neither will touch a key outside the `videos/` prefix, and
// readVideoObjectBytes also refuses a non-positive length (lib/r2.ts:407 and
// :440). A stub that answers for any key disarms those guards for every api
// suite at once, so a route that heads or reads the wrong object key would
// look perfectly healthy. The prefix is written out here rather than imported
// from lib/video-upload-validation, so that changing it fails loudly instead
// of the stub agreeing with the change.
headVideoObject: vi.fn(async (key: string) => {
if (!key.startsWith('videos/')) return null;
return { contentLength: BigInt(1024), contentType: 'video/mp4' };
}),
// 64 bytes with an `ftyp` box at offset 4, the ISO base media signature the
// first branch of hasKnownVideoMagicBytes() looks for, trimmed to the length
// the caller asked for the way a real ranged GET would be. A suite that needs
// a rejected upload overrides this per test.
readVideoObjectBytes: vi.fn(async (key: string, byteLength: number) => {
if (!key.startsWith('videos/') || byteLength <= 0) return null;
const header = new Uint8Array(64);
header.set([0x00, 0x00, 0x00, 0x20], 0);
header.set([0x66, 0x74, 0x79, 0x70], 4); // 'ftyp'
header.set([0x69, 0x73, 0x6f, 0x6d], 8); // 'isom'
return header.slice(0, Math.min(header.length, byteLength));
}),
ensureR2BucketExists: vi.fn(async () => undefined),
ensureR2UploadCors: vi.fn(async () => []),
};
});
// ---------------------------------------------------------------------------
// Stripe
// ---------------------------------------------------------------------------
// getStripe() is the single seam every Stripe call goes through. Suites that
// need a specific response (the webhook suite, mainly) override these per test.
vi.mock('@/lib/stripe', async (importOriginal) => {
const actual = await importOriginal<typeof import('@/lib/stripe')>();
return {
...actual,
getStripe: vi.fn(() => ({
customers: { create: vi.fn(async () => ({ id: 'cus_test_default' })) },
subscriptions: { list: vi.fn(async () => ({ data: [] })) },
checkout: {
sessions: { create: vi.fn(async () => ({ url: 'https://stripe.test/checkout' })) },
},
billingPortal: {
sessions: { create: vi.fn(async () => ({ url: 'https://stripe.test/portal' })) },
},
webhooks: {
constructEvent: vi.fn(() => {
throw new Error('stripe.webhooks.constructEvent was not stubbed for this test');
}),
},
})),
};
});
// ---------------------------------------------------------------------------
// Bunny storage stats
// ---------------------------------------------------------------------------
// getCachedUserBunnyStorage() is an HTTP call to the Bunny API, and it sits in
// the middle of reserveStorageQuota(). Default to "no Bunny bytes"; the quota
// suite overrides it to prove Bunny usage counts against the limit.
vi.mock('@/lib/admin-stats', async (importOriginal) => {
const actual = await importOriginal<typeof import('@/lib/admin-stats')>();
return {
...actual,
getCachedUserBunnyStorage: vi.fn(async () => ({}) as Record<string, number>),
};
});
// ---------------------------------------------------------------------------
// Notifications
// ---------------------------------------------------------------------------
// notifyUsers()/notifyProjectOwner() fan out to Telegram over fetch() and to
// SMTP. Tests assert on the rows a route writes, not on delivery.
vi.mock('@/lib/notifications', async (importOriginal) => {
const actual = await importOriginal<typeof import('@/lib/notifications')>();
return {
...actual,
notifyUsers: vi.fn(async () => undefined),
notifyProjectOwner: vi.fn(async () => undefined),
};
});
// ---------------------------------------------------------------------------
// Mail
// ---------------------------------------------------------------------------
// SMTP_* is configured in .env.test on purpose, so isEmailVerificationEnabled()
// is true and the routes take their production branch. Messages are captured
// instead of sent; assert on them with tests/helpers/mail.ts.
vi.mock('nodemailer', async () => {
const { recordSentMail } = await import('../helpers/mail');
const createTransport = vi.fn(() => ({
sendMail: vi.fn(async (message: unknown) => {
recordSentMail(message);
return { messageId: 'test-message-id', accepted: [], rejected: [] };
}),
verify: vi.fn(async () => true),
}));
return { default: { createTransport }, createTransport };
});
// ---------------------------------------------------------------------------
// Lifecycle
// ---------------------------------------------------------------------------
// A stale database from a crashed previous run would otherwise leak into the
// first test of the file.
beforeAll(async () => {
await resetDb();
});
beforeEach(() => {
resetSentMail();
});
// Every test creates the data it needs and nothing survives it, so no test can
// depend on execution order or on another test's rows.
afterEach(async () => {
// Vitest's `unstubEnvs` option defaults to false, so a vi.stubEnv() leaks into
// every following test in the file. That is not a theoretical worry here: one
// test turning OPENFRAME_ENABLE_STRIPE off silently disarms hasBillingAccess()
// and every quota check for the rest of the file, and the tests that follow
// pass for the wrong reason. Undo it centrally rather than trusting 13 files
// to remember.
vi.unstubAllEnvs();
await resetDb();
});