Files
OpenFrame/lib/storage-quota.ts
T
yusufipek 4ff801738c fix(uploads): count a Bunny upload from the moment it is admitted
A Bunny init asked the quota whether it could store zero bytes, which is a
question with only one answer. Nothing an upload was about to consume was
visible to the next request, so every init inside the same window read the
same total and every one of them passed, and an upload that could never
fit was only refused after it had been sent.

The client now declares the size up front. It is checked against the
account's remaining room before Bunny is asked for anything, and held as
a reservation the next init has to see. The declaration is a claim rather
than proof, so it is signed into the upload token: the same token already
binds the video id, which is what makes the reservation safe to release
on a caller's say-so, since releasing it costs them the video it belongs
to.

The declared size is then written onto the version or asset row and the
reservation is dropped in the same transaction, because Bunny reports no
size at all for a video until it has finished encoding it. On a half hour
of footage that is most of an hour during which the upload did not appear
on the uploader's own storage page and did not count against the next
upload. Per-video accounting now takes the larger of what Bunny reports
and what was declared, so the estimate stands in until the real figure
arrives and Bunny's wins once it does.

Two smaller things came out of the same reading. The asset route's
in-transaction fallback compared against the plan limit, so a caller
quoting a reservation that no longer existed was measured against 200 GiB
even on a trial worth three. And the guest branch reserves without being
able to release early, because a guest grant is bound to our video id and
the caller's network context rather than to the Bunny video, which would
let the reservation be dropped while the upload it stands for carried on.
2026-08-18 10:35:08 +03:00

234 lines
8.2 KiB
TypeScript

import type { NextResponse } from 'next/server';
import { db } from '@/lib/db';
import { apiErrors } from '@/lib/api-response';
import { isStripeFeatureEnabled } from '@/lib/feature-flags';
import { getCachedUserBunnyStorage } from '@/lib/admin-stats';
import { isPaidTier } from '@/lib/billing';
import { getStorageLimitBytes } from '@/lib/trial-limits';
// 200 GB expressed in bytes
export const PLAN_STORAGE_LIMIT_BYTES = BigInt(200) * BigInt(1024) * BigInt(1024) * BigInt(1024);
/**
* The ceiling this particular account is held to.
*
* A cardless trial gets a much smaller one: it is the only thing standing between
* a throwaway signup and 200 GB of our storage. Reads the two billing columns
* directly rather than taking a flag from the caller, so no upload route can
* forget to pass it.
*/
export async function getStorageLimitForUser(userId: string): Promise<bigint> {
const user = await db.user.findUnique({
where: { id: userId },
select: { subscriptionStatus: true, stripeCurrentPeriodEnd: true },
});
return getStorageLimitBytes(user ? isPaidTier(user) : false, PLAN_STORAGE_LIMIT_BYTES);
}
// TTL for upload reservations: 30 minutes is enough for R2 image/audio uploads
const RESERVATION_TTL_MS = 30 * 60 * 1000;
// Sentinel error thrown inside a Prisma transaction to signal quota exceeded
class QuotaExceededError extends Error {}
/**
* Returns total bytes used by a given billed user across R2 (image + audio),
* Bunny Stream, and any active (non-expired) upload reservations.
* Uses the cached Bunny stats (10-min TTL) to avoid calling the Bunny API on
* every upload.
*/
export async function getUserTotalStorageBytes(userId: string): Promise<bigint> {
const [r2AssetRows, r2VideoRows, bunnyByUser, reservationRows] = await Promise.all([
db.$queryRaw<[{ total: bigint }]>`
SELECT COALESCE(SUM(size_bytes), 0)::bigint AS total
FROM video_assets
WHERE "billedUserId" = ${userId}
AND provider IN ('R2_IMAGE', 'R2_AUDIO', 'R2_VIDEO')
`,
db.$queryRaw<[{ total: bigint }]>`
SELECT COALESCE(SUM(vv.size_bytes), 0)::bigint AS total
FROM video_versions vv
INNER JOIN videos v ON v.id = vv."videoParentId"
INNER JOIN projects p ON p.id = v."projectId"
INNER JOIN workspaces w ON w.id = p."workspaceId"
WHERE w."ownerId" = ${userId}
AND vv."providerId" = 'r2'
`,
getCachedUserBunnyStorage(),
db.$queryRaw<[{ total: bigint }]>`
SELECT COALESCE(SUM("sizeBytes"), 0)::bigint AS total
FROM upload_reservations
WHERE "billedUserId" = ${userId}
AND "expiresAt" > NOW()
`,
]);
const r2AssetBytes = r2AssetRows[0]?.total ?? BigInt(0);
const r2VideoBytes = r2VideoRows[0]?.total ?? BigInt(0);
const bunnyBytes = BigInt(bunnyByUser[userId] ?? 0);
const reservedBytes = reservationRows[0]?.total ?? BigInt(0);
return r2AssetBytes + r2VideoBytes + bunnyBytes + reservedBytes;
}
/**
* Returns storage usage info for a user in a UI-friendly shape.
*/
export async function getUserStorageInfo(userId: string): Promise<{
usedBytes: bigint;
limitBytes: bigint;
percentage: number;
}> {
const [usedBytes, limitBytes] = await Promise.all([
getUserTotalStorageBytes(userId),
getStorageLimitForUser(userId),
]);
const percentage =
limitBytes > BigInt(0)
? Math.min(100, Number((usedBytes * BigInt(10000)) / limitBytes) / 100)
: 0;
return { usedBytes, limitBytes, percentage };
}
/**
* Checks whether the user can upload `incomingSizeBytes` more data.
*
* Returns a 507 response if the quota would be exceeded, or `null` if the
* upload is allowed. When Stripe is disabled the check is always skipped so
* self-hosted instances without billing still work.
*
* Uses `>=` so a user at exactly the limit cannot initiate new uploads.
*/
export async function enforceStorageQuota(
userId: string,
incomingSizeBytes: bigint
): Promise<NextResponse | null> {
if (!isStripeFeatureEnabled()) {
return null;
}
const [usedBytes, limitBytes] = await Promise.all([
getUserTotalStorageBytes(userId),
getStorageLimitForUser(userId),
]);
if (usedBytes + incomingSizeBytes >= limitBytes) {
return apiErrors.storageExceeded() as NextResponse;
}
return null;
}
/**
* Atomically checks the quota and records an in-flight upload reservation.
*
* Uses a PostgreSQL advisory transaction lock (per user) so concurrent callers
* are serialised: the second request sees the first reservation in the sum and
* cannot double-book the same headroom.
*
* Returns `{ reservationId }` on success or `{ error }` (a 507 NextResponse)
* when the quota would be exceeded. Call `releaseStorageReservation` to delete
* the reservation once the paired asset is committed (or if the upload fails).
*
* When Stripe is disabled the check is skipped and `reservationId` is `null`.
*/
export async function reserveStorageQuota(
userId: string,
incomingSizeBytes: bigint,
reservationTtlMs: number = RESERVATION_TTL_MS
): Promise<{ reservationId: string | null } | { error: NextResponse }> {
if (!isStripeFeatureEnabled()) {
return { reservationId: null };
}
const expiresAt = new Date(Date.now() + reservationTtlMs);
// Fetch Bunny storage and the account's ceiling BEFORE entering the transaction,
// to avoid holding the advisory lock during a potentially slow/failing HTTP call
// on cache miss or an extra round trip to Postgres.
const [bunnyData, limitBytes] = await Promise.all([
getCachedUserBunnyStorage(),
getStorageLimitForUser(userId),
]);
const bunnyBytes = BigInt(bunnyData[userId] ?? 0);
try {
const reservationId = await db.$transaction(async (tx) => {
// Serialise quota checks for this user via a per-user advisory lock.
// Combine two 32-bit hashtext() halves into a single 64-bit bigint to
// eliminate the 32-bit hash-space collision risk of plain hashtext().
// Use $executeRaw — the function returns void which $queryRaw cannot deserialize.
await tx.$executeRaw`
SELECT pg_advisory_xact_lock(
('x' || left(md5(${userId}), 16))::bit(64)::bigint
)
`;
// Read committed R2 storage under the lock
const [r2AssetRow] = await tx.$queryRaw<[{ total: bigint }]>`
SELECT COALESCE(SUM(size_bytes), 0)::bigint AS total
FROM video_assets
WHERE "billedUserId" = ${userId}
AND provider IN ('R2_IMAGE', 'R2_AUDIO', 'R2_VIDEO')
`;
const [r2VideoRow] = await tx.$queryRaw<[{ total: bigint }]>`
SELECT COALESCE(SUM(vv.size_bytes), 0)::bigint AS total
FROM video_versions vv
INNER JOIN videos v ON v.id = vv."videoParentId"
INNER JOIN projects p ON p.id = v."projectId"
INNER JOIN workspaces w ON w.id = p."workspaceId"
WHERE w."ownerId" = ${userId}
AND vv."providerId" = 'r2'
`;
const r2Bytes = (r2AssetRow?.total ?? BigInt(0)) + (r2VideoRow?.total ?? BigInt(0));
// Read active (non-expired) reservations under the same lock
const [resRow] = await tx.$queryRaw<[{ total: bigint }]>`
SELECT COALESCE(SUM("sizeBytes"), 0)::bigint AS total
FROM upload_reservations
WHERE "billedUserId" = ${userId}
AND "expiresAt" > NOW()
`;
const reservedBytes = resRow?.total ?? BigInt(0);
const totalUsed = r2Bytes + reservedBytes + bunnyBytes;
if (totalUsed + incomingSizeBytes >= limitBytes) {
throw new QuotaExceededError();
}
const reservation = await tx.uploadReservation.create({
data: { billedUserId: userId, sizeBytes: incomingSizeBytes, expiresAt },
select: { id: true },
});
return reservation.id;
});
return { reservationId };
} catch (e) {
if (e instanceof QuotaExceededError) {
return { error: apiErrors.storageExceeded() as NextResponse };
}
throw e;
}
}
/**
* Deletes an upload reservation created by `reserveStorageQuota`.
* Safe to call with `null` (no-op) for flows where billing is disabled.
*/
export async function releaseStorageReservation(
reservationId: string | null,
billedUserId?: string | null
): Promise<void> {
if (!reservationId) return;
await db.uploadReservation.deleteMany({
where: {
id: reservationId,
...(billedUserId ? { billedUserId } : {}),
},
});
}