mirror of
https://github.com/yusufipk/OpenFrame.git
synced 2026-09-11 09:36:08 +00:00
yusufipek
b9e2006e34
A comment held one image, and the paste handler took the first item off the clipboard and dropped the rest. Reviewing a cut usually means several screenshots about the same moment, which meant one comment per screenshot or one screenshot and a paragraph describing the others. Editing a comment could not attach anything at all: the edit box had no paste handler, no file picker and no way to remove what was already there. A comment now carries up to five images, in the composer, in a reply and in the editor. One paste stages every image on the clipboard, the file picker takes a multiple selection, and a drop lands on whichever editor is open. Over the cap the extras are refused out loud rather than dropped quietly. A single image still fills the width; several tile into a grid, and either opens full screen on click. The images move into their own table. `comments.imageUrl` stays and follows the first of them, so a reader that has not been updated keeps working, and the migration copies the existing attachments across so the new table is complete from the first read. Every path that resolves a URL back to a comment now asks the new table: R2 cleanup, the orphan sweep, the storage accounting and the reference checks that decide whether an object can be deleted. Left on the old column they would have treated images two through five as unreferenced and swept them. Detaching an image while editing only breaks the link. The file stays in R2 and in the assets pane, which is where it is deleted from and where its bytes are already billed.
29 lines
1.3 KiB
SQL
29 lines
1.3 KiB
SQL
-- A comment used to hold at most one image, in "comments"."imageUrl". Screenshots
|
|
-- arrive in batches, so the images move into their own table and the old column
|
|
-- stays as a pointer to the first one for readers that have not been updated.
|
|
CREATE TABLE "comment_images" (
|
|
"id" TEXT NOT NULL,
|
|
"url" TEXT NOT NULL,
|
|
"position" INTEGER NOT NULL DEFAULT 0,
|
|
"commentId" TEXT NOT NULL,
|
|
"createdAt" TIMESTAMP(3) NOT NULL DEFAULT CURRENT_TIMESTAMP,
|
|
|
|
CONSTRAINT "comment_images_pkey" PRIMARY KEY ("id")
|
|
);
|
|
|
|
-- An uploaded file belongs to exactly one comment, which is what the old
|
|
-- "comments_imageUrl_key" guaranteed. Reference checks before an R2 delete
|
|
-- rely on it.
|
|
CREATE UNIQUE INDEX "comment_images_url_key" ON "comment_images"("url");
|
|
CREATE INDEX "comment_images_commentId_position_idx" ON "comment_images"("commentId", "position");
|
|
|
|
ALTER TABLE "comment_images" ADD CONSTRAINT "comment_images_commentId_fkey"
|
|
FOREIGN KEY ("commentId") REFERENCES "comments"("id") ON DELETE CASCADE ON UPDATE CASCADE;
|
|
|
|
-- Existing single attachments become the first image of their comment, so the
|
|
-- new table is the complete list from the first read after this migration.
|
|
INSERT INTO "comment_images" ("id", "url", "position", "commentId", "createdAt")
|
|
SELECT gen_random_uuid()::text, "imageUrl", 0, "id", "createdAt"
|
|
FROM "comments"
|
|
WHERE "imageUrl" IS NOT NULL;
|