mirror of
https://github.com/yusufipk/OpenFrame.git
synced 2026-09-11 09:36:08 +00:00
yusufipek
fe1faeced4
The Stripe client was built without an apiVersion, so the SDK followed whatever version it shipped with. Two fields moved in the Basil API version: the billing period went from the subscription onto its items, and the invoice link to its subscription went under parent.subscription_details. Both reads returned undefined without failing, which left stripeCurrentPeriodEnd null for every subscriber and left the app with no invoice handling at all. A customer whose card failed saw nothing about the invoice that was still retrying, and a cancellation did nothing to stop those retries. - Pin the API version, with `satisfies` so an SDK bump is a compile error here before it is a null read in production. - Read the period off subscription items and the subscription off invoice parents, keeping the legacy fields as a fallback for older payloads. - Handle invoice.paid, invoice.payment_failed, invoice.voided and invoice.marked_uncollectible through the existing customer-wide resync, so the mirror reflects payment health during dunning rather than after it. - Add an in-app cancellation route: at period end when the subscription is paid, immediately plus voiding the open invoices when it is not, because cancelling alone does not stop collection on an invoice already issued. - Ask Stripe, not just the local mirror, before opening checkout. - Show the open invoice, the retry date and a payment-method-update shortcut in settings, and put a confirmation in front of cancellation. Access no longer rests on the reported period alone. Stripe advances the period when it issues the renewal invoice, paid or not, and the period survives cancellation, so once the period field started being read correctly that check would have handed a full free month to anyone whose renewal failed, and the new cancel route would have let them void the invoice and keep the month. Access now follows the subscription status, billingAccessEndedAt is enforced as a hard cutoff in both hasBillingAccess and the query that mirrors it, and a subscription behind on payment keeps access for Stripe's retry window rather than for the period it never paid for.
79 lines
2.8 KiB
TypeScript
79 lines
2.8 KiB
TypeScript
import { NextRequest } from 'next/server';
|
|
import { auth } from '@/lib/auth';
|
|
import { apiErrors, successResponse, withCacheControl } from '@/lib/api-response';
|
|
import {
|
|
findLiveStripeSubscription,
|
|
getBillingOverview,
|
|
isUnpaidStripeSubscription,
|
|
syncStripeSubscriptionToUser,
|
|
voidOpenSubscriptionInvoices,
|
|
} from '@/lib/billing';
|
|
import { rateLimit } from '@/lib/rate-limit';
|
|
import { isStripeFeatureEnabled } from '@/lib/feature-flags';
|
|
import { getStripe, isStripeConfigured } from '@/lib/stripe';
|
|
import { isTrustedSameOriginRequest } from '@/lib/request-origin';
|
|
import { logError } from '@/lib/logger';
|
|
|
|
export async function POST(request: NextRequest) {
|
|
try {
|
|
const limited = await rateLimit(request, 'mutate');
|
|
if (limited) return limited;
|
|
|
|
if (!isTrustedSameOriginRequest(request)) {
|
|
return apiErrors.forbidden('Invalid request origin');
|
|
}
|
|
|
|
const session = await auth();
|
|
if (!session?.user?.id) {
|
|
return apiErrors.unauthorized();
|
|
}
|
|
|
|
if (!isStripeFeatureEnabled()) {
|
|
return apiErrors.badRequest('Stripe billing is disabled by this host');
|
|
}
|
|
|
|
if (!isStripeConfigured()) {
|
|
return apiErrors.internalError('Stripe billing is not configured');
|
|
}
|
|
|
|
const billing = await getBillingOverview(session.user.id);
|
|
const customerId = billing.subscription.stripeCustomerId;
|
|
if (!customerId) {
|
|
return apiErrors.badRequest('No Stripe customer exists for this account');
|
|
}
|
|
|
|
const subscription = await findLiveStripeSubscription(customerId);
|
|
if (!subscription) {
|
|
return apiErrors.badRequest('No subscription to cancel');
|
|
}
|
|
|
|
const stripe = getStripe();
|
|
const unpaid = isUnpaidStripeSubscription(subscription);
|
|
|
|
// Scheduling an unpaid subscription to the end of its period leaves the customer
|
|
// owing money for a period they never paid for, while the already issued invoice
|
|
// keeps retrying their card on its own. Those cancel immediately instead, and the
|
|
// invoice for the unserved period is voided in the same pass.
|
|
const canceled = unpaid
|
|
? await stripe.subscriptions.cancel(subscription.id)
|
|
: await stripe.subscriptions.update(subscription.id, { cancel_at_period_end: true });
|
|
|
|
const voidedInvoices = unpaid
|
|
? await voidOpenSubscriptionInvoices(customerId, subscription.id)
|
|
: [];
|
|
|
|
await syncStripeSubscriptionToUser(canceled);
|
|
|
|
const response = successResponse({
|
|
canceledImmediately: unpaid,
|
|
status: canceled.status,
|
|
cancelAt: canceled.cancel_at ? new Date(canceled.cancel_at * 1000).toISOString() : null,
|
|
voidedInvoices,
|
|
});
|
|
return withCacheControl(response, 'private, no-store');
|
|
} catch (error) {
|
|
logError('Error canceling Stripe subscription:', error);
|
|
return apiErrors.internalError('Failed to cancel subscription');
|
|
}
|
|
}
|