yusufipek/RepoHub
1
0
Fork 0
mirror of https://github.com/yusufipk/RepoHub.git synced 2026-09-11 10:36:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Remove useRecommendationProfile hook dependency and derive state from props in RecommendationsSection

Browse Source 
- Replace hook-based state management with direct prop-based state derivation
- Implement getEffectiveOS and isProfileComplete as inline functions using profile prop
- Remove effectiveProfile intermediate variable and use profile prop directly
- Update all references from effectiveProfile to profile throughout component
- Simplify component dependencies by removing hook coupling
This commit is contained in:
Yusuf İpek
2025-11-23 14:28:59 +03:00
parent 9266de1f3e
commit d66c02b7fa
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/RecommendationsSection.tsx
+10 -8
View File
@@ -32,9 +32,11 @@ export function RecommendationsSection({
profile profile
}: RecommendationsSectionProps) { }: RecommendationsSectionProps) {
const { t } = useLocale() const { t } = useLocale()
const { getEffectiveOS, isProfileComplete } = useRecommendationProfile()
// Override profile from hook with prop // Derived state from props
const effectiveProfile = profile const getEffectiveOS = () => profile.selectedOS || profile.detectedOS || "ubuntu"
const isProfileComplete = () => profile.categories.length > 0 && getEffectiveOS() !== "unknown"
const [recommendations, setRecommendations] = useState<RecommendedPackage[]>([]) const [recommendations, setRecommendations] = useState<RecommendedPackage[]>([])
const [loading, setLoading] = useState(false) const [loading, setLoading] = useState(false)
const [error, setError] = useState<string | null>(null) const [error, setError] = useState<string | null>(null)
@@ -59,8 +61,8 @@ export function RecommendationsSection({
}, },
body: JSON.stringify({ body: JSON.stringify({
platform_id: getEffectiveOS(), platform_id: getEffectiveOS(),
categories: effectiveProfile.categories, categories: profile.categories,
experienceLevel: effectiveProfile.experienceLevel, experienceLevel: profile.experienceLevel,
limit: 1000 limit: 1000
}) })
}) })
@@ -103,7 +105,7 @@ export function RecommendationsSection({
// But for now, let's rely on the cache key changing which includes profile data // But for now, let's rely on the cache key changing which includes profile data
fetchRecommendations() fetchRecommendations()
} }
}, [effectiveProfile.categories, effectiveProfile.selectedOS, effectiveProfile.experienceLevel]) }, [profile.categories, profile.selectedOS, profile.experienceLevel])
const isPackageSelected = (pkg: RecommendedPackage) => { const isPackageSelected = (pkg: RecommendedPackage) => {
return selectedPackages.some(selected => selected.id === pkg.id) return selectedPackages.some(selected => selected.id === pkg.id)
@@ -239,7 +241,7 @@ export function RecommendationsSection({
<span className="text-xs px-2 py-1 rounded-full bg-primary/10 text-primary"> <span className="text-xs px-2 py-1 rounded-full bg-primary/10 text-primary">
{getEffectiveOS()} {getEffectiveOS()}
</span> </span>
{effectiveProfile.categories.map(cat => ( {profile.categories.map(cat => (
<span <span
key={cat} key={cat}
className="text-xs px-2 py-1 rounded-full bg-secondary text-secondary-foreground" className="text-xs px-2 py-1 rounded-full bg-secondary text-secondary-foreground"
@@ -269,7 +271,7 @@ export function RecommendationsSection({
> >
All ({recommendations.length}) All ({recommendations.length})
</Button> </Button>
{effectiveProfile.categories.map(cat => { {profile.categories.map(cat => {
const count = getCategoryCount(cat) const count = getCategoryCount(cat)
const Icon = CATEGORY_ICONS[cat] const Icon = CATEGORY_ICONS[cat]
return ( return (