Files
OpenFrame/app/(auth)/login/login-form.tsx
T
yusufipk b51e690062 fix: close the findings the test suite surfaced
The suite that landed in #43/#44 was written against existing behaviour, so a
number of tests pinned bugs rather than asserting correct behaviour. This fixes
the production code and moves each of those tests onto the fixed behaviour in
the same change.

Security:

- project-download: derive the archive entry extension from the last path
  segment and restrict it to a short alphanumeric run, so an extensionless
  allowlisted url can no longer contribute a path separator; validate the r2
  branch against the strict proxy-path pattern instead of a `startsWith`, which
  let `/api/upload/video/clip.mp4/../../etc/passwd` through verbatim.
- rate-limit: hash a key or action wider than its column instead of skipping the
  query. Both the guard and the failing INSERT used to answer "allowed", so the
  limit stopped applying entirely. Warn at startup when TRUSTED_PROXY_MODE is
  unset in production.
- video uploads: the file name decides the content type; a client-declared video
  mime no longer makes `payload.exe` acceptable.
- email templates: escape in the helpers rather than relying on every caller,
  with an explicit `rawEmailHtml()` opt-out for the one call site that builds
  markup. `escapeHtml` now covers the single quote.
- CSP: allow loopback object storage outside production only.
- route-access: reach the billing redirect only for the workspace owner. Keying
  it off the owner's billing status alone made the redirect target an oracle for
  whose subscription had lapsed, and sent members to a page they cannot act on.
- search: carry the same billing condition every other read path carries.
- logger: check `err.name` as well as `err.constructor.name`, so a re-thrown,
  deserialised or minified Prisma error is still redacted.
- upload tokens: resolve the signing secret outside the try, so a server booted
  without one fails loudly instead of reporting every grant as a forgery.
- invitations: never downgrade an existing membership, and report a scoped
  invitation that points at nothing as not_found rather than accepted.
- auth: resolve the workspace role for every signed-in caller, so
  checkProjectAccess and computeProjectAccess stop disagreeing about the owner
  who also owns the workspace. The `intent` option is gone with it.
- r2-media-proxy: validate the object key inside the proxy so the guard travels
  with the function; delete the unused, unanchored `mediaUrlToR2Key`.
- r2: sign the content type into presigned PUT grants.

Correctness:

- frame rate snapping picks the nearest standard, not the first within
  tolerance, so 24, 30 and 60 fps are reachable at all.
- a version upload registers its Bunny cleanup as soon as bunny-init answers, so
  a failed tus upload no longer leaves a billed video behind.
- deleting videos clears storage before the rows, so a refused DELETE leaves a
  retryable row rather than an orphaned object.
- an expired upload session can be cancelled, which is what releases its quota.
- `voice/` joins the delete allowlist, so a voice note can be removed by the
  module that wrote it.
- a failed CORS write propagates instead of being mistaken for an empty config
  and replacing the bucket's rules.
- filtering projects by workspace no longer hides projects the unfiltered call
  returns.
- upload retries skip aborts and permanent 4xx; progress no longer divides by
  zero.
- reply edits no longer clear the comment's tag; optimistic resolve rolls back
  to the state it replaced; the delete snapshot is captured once.
- assorted UI fixes: duplicate React keys, double-click guards reading stale
  closures, the tag list fetched twice per load, a failed member list rendering
  as an empty one, a stale "Initializing upload..." beside a failure, and a
  registration banner pointing at an email that never arrives.

Consistency and access:

- the two download routes answer 404 for an id belonging to another tenant, as
  the comment export route already did. A caller who does belong still gets 403.
- accessible names for the share-link password field, the guest name gates, the
  version dialog inputs and the comment-tag controls.

Repository health:

- the runner image installs production dependencies only.
- a setup file for the unit project restores stubbed env centrally.
- native tsconfig path resolution replaces vite-tsconfig-paths.
- `uploadBytesWithProgress` exists once.
- admin stats bill Bunny storage to the workspace owner like every other
  quota, gate on the configured flag, wire up the single-flight guard and count
  the statuses that belonged to no bucket.
- `r2Client.destroy()` releases the presign client too.
- `prepare` tolerates a production install, where husky is absent.
2026-07-26 18:53:54 +07:00

298 lines
11 KiB
TypeScript

'use client';
import { useState, useEffect, Suspense } from 'react';
import Link from 'next/link';
import { useRouter, useSearchParams } from 'next/navigation';
import { Loader2 } from 'lucide-react';
import { Button } from '@/components/ui/button';
import { Card, CardContent, CardDescription, CardHeader, CardTitle } from '@/components/ui/card';
import { Input } from '@/components/ui/input';
import { Label } from '@/components/ui/label';
import { signIn } from 'next-auth/react';
import {
getSafeCallbackUrl,
isInvitationCallbackUrl,
isSafeRelativePath,
} from '@/lib/safe-redirect';
/**
* Sign-up link that carries the pending destination — and, when that destination is an
* invitation, the invitation token itself so the new account is bound to the invite.
*/
function buildRegisterHref(callbackUrl: string): string {
if (callbackUrl === '/dashboard') return '/register';
const params = new URLSearchParams({ callbackUrl });
if (isInvitationCallbackUrl(callbackUrl)) {
const token = new URLSearchParams(callbackUrl.split('?')[1] ?? '').get('token');
if (token) params.set('invitationToken', token);
}
return `/register?${params.toString()}`;
}
const ERROR_MESSAGES: Record<string, string> = {
RegistrationClosed: 'Sign-up is currently invite-only. Contact an administrator.',
// Generic message — avoid confirming whether a credentials account exists for this email
OAuthAccountNotLinked: 'Sign-in failed. Please try a different method or contact support.',
OAuthCallbackError: 'OAuth sign-in failed. Please try again.',
OAuthEmailNotVerified:
'Your OAuth account email is not verified. Please verify it with your provider and try again.',
InvalidVerificationToken: 'The verification link is invalid or has expired.',
VerificationFailed: 'Email verification failed. Please try again.',
Default: 'Something went wrong. Please try again.',
};
interface LoginFormInnerProps {
googleEnabled: boolean;
githubEnabled: boolean;
}
function LoginFormInner({ googleEnabled, githubEnabled }: LoginFormInnerProps) {
const router = useRouter();
const searchParams = useSearchParams();
const [isLoading, setIsLoading] = useState(false);
const [oauthLoading, setOauthLoading] = useState<string | null>(null);
const [error, setError] = useState('');
const [email, setEmail] = useState('');
const [password, setPassword] = useState('');
const [showSuccess, setShowSuccess] = useState(false);
const [showVerifiedSuccess, setShowVerifiedSuccess] = useState(false);
const callbackUrl = getSafeCallbackUrl(searchParams.get('callbackUrl'));
const isInvitationFlow = isInvitationCallbackUrl(callbackUrl);
const registerHref = buildRegisterHref(callbackUrl);
useEffect(() => {
if (searchParams.get('registered') === 'true') {
setShowSuccess(true);
}
if (searchParams.get('verified') === 'true') {
setShowVerifiedSuccess(true);
}
const errorCode = searchParams.get('error');
if (errorCode) {
setError(ERROR_MESSAGES[errorCode] ?? ERROR_MESSAGES.Default);
}
}, [searchParams]);
const handleEmailLogin = async (e: React.FormEvent) => {
e.preventDefault();
setIsLoading(true);
setError('');
try {
const result = await signIn('credentials', {
email,
password,
redirect: false,
callbackUrl,
});
if (result?.error) {
setError('Invalid email or password');
return;
}
// `result.url` is whatever next-auth resolved, so it is sanitized again here — and
// re-checked at the sink, because `router.push` happily leaves the origin.
const destination = getSafeCallbackUrl(result?.url || callbackUrl);
router.push(isSafeRelativePath(destination) ? destination : '/dashboard');
router.refresh();
} catch {
setError('Something went wrong. Please try again.');
} finally {
setIsLoading(false);
}
};
const handleOAuthLogin = async (provider: string) => {
setOauthLoading(provider);
setError('');
await signIn(provider, { callbackUrl });
};
const hasOAuth = googleEnabled || githubEnabled;
const anyLoading = isLoading || oauthLoading !== null;
return (
<Card>
<CardHeader className="text-center">
<CardTitle>Welcome back</CardTitle>
<CardDescription>
{isInvitationFlow
? 'Sign in to accept your invitation'
: 'Sign in to your account to continue'}
</CardDescription>
</CardHeader>
<CardContent>
{/*
`?registered=true` is only ever reached when email verification is off: the
register page sends a user who has to verify to /verify-email instead. Telling
this one to go and check a mailbox pointed them at a message that never arrives,
on a self-hosted deployment without SMTP, which is the documented default.
*/}
{showSuccess && (
<div className="p-3 rounded-md bg-green-500/10 text-green-600 text-sm mb-4">
Account created successfully! You can sign in now.
</div>
)}
{showVerifiedSuccess && (
<div className="p-3 rounded-md bg-green-500/10 text-green-600 text-sm mb-4">
Email verified successfully! You can now sign in.
</div>
)}
{error && (
<div className="p-3 rounded-md bg-destructive/10 text-destructive text-sm mb-4">
{error}
</div>
)}
{/* OAuth Buttons */}
{hasOAuth && (
<div className="space-y-2 mb-4">
{googleEnabled && (
<Button
type="button"
variant="outline"
className="w-full"
disabled={anyLoading}
onClick={() => handleOAuthLogin('google')}
>
{oauthLoading === 'google' ? (
<Loader2 className="h-4 w-4 mr-2 animate-spin" />
) : (
<svg className="h-4 w-4 mr-2" viewBox="0 0 24 24" aria-hidden="true">
<path
d="M22.56 12.25c0-.78-.07-1.53-.2-2.25H12v4.26h5.92c-.26 1.37-1.04 2.53-2.21 3.31v2.77h3.57c2.08-1.92 3.28-4.74 3.28-8.09z"
fill="#4285F4"
/>
<path
d="M12 23c2.97 0 5.46-.98 7.28-2.66l-3.57-2.77c-.98.66-2.23 1.06-3.71 1.06-2.86 0-5.29-1.93-6.16-4.53H2.18v2.84C3.99 20.53 7.7 23 12 23z"
fill="#34A853"
/>
<path
d="M5.84 14.09c-.22-.66-.35-1.36-.35-2.09s.13-1.43.35-2.09V7.07H2.18C1.43 8.55 1 10.22 1 12s.43 3.45 1.18 4.93l2.85-2.22.81-.62z"
fill="#FBBC05"
/>
<path
d="M12 5.38c1.62 0 3.06.56 4.21 1.64l3.15-3.15C17.45 2.09 14.97 1 12 1 7.7 1 3.99 3.47 2.18 7.07l3.66 2.84c.87-2.6 3.3-4.53 6.16-4.53z"
fill="#EA4335"
/>
</svg>
)}
Continue with Google
</Button>
)}
{githubEnabled && (
<Button
type="button"
variant="outline"
className="w-full"
disabled={anyLoading}
onClick={() => handleOAuthLogin('github')}
>
{oauthLoading === 'github' ? (
<Loader2 className="h-4 w-4 mr-2 animate-spin" />
) : (
<svg
className="h-4 w-4 mr-2"
viewBox="0 0 24 24"
aria-hidden="true"
fill="currentColor"
>
<path d="M12 2C6.477 2 2 6.484 2 12.017c0 4.425 2.865 8.18 6.839 9.504.5.092.682-.217.682-.483 0-.237-.008-.868-.013-1.703-2.782.605-3.369-1.343-3.369-1.343-.454-1.158-1.11-1.466-1.11-1.466-.908-.62.069-.608.069-.608 1.003.07 1.531 1.032 1.531 1.032.892 1.53 2.341 1.088 2.91.832.092-.647.35-1.088.636-1.338-2.22-.253-4.555-1.113-4.555-4.951 0-1.093.39-1.988 1.029-2.688-.103-.253-.446-1.272.098-2.65 0 0 .84-.27 2.75 1.026A9.564 9.564 0 0112 6.844c.85.004 1.705.115 2.504.337 1.909-1.296 2.747-1.027 2.747-1.027.546 1.379.202 2.398.1 2.651.64.7 1.028 1.595 1.028 2.688 0 3.848-2.339 4.695-4.566 4.943.359.309.678.92.678 1.855 0 1.338-.012 2.419-.012 2.747 0 .268.18.58.688.482A10.019 10.019 0 0022 12.017C22 6.484 17.522 2 12 2z" />
</svg>
)}
Continue with GitHub
</Button>
)}
</div>
)}
{/* Divider */}
{hasOAuth && (
<div className="relative mb-4">
<div className="absolute inset-0 flex items-center">
<span className="w-full border-t" />
</div>
<div className="relative flex justify-center text-xs uppercase">
<span className="bg-card px-2 text-muted-foreground">or continue with email</span>
</div>
</div>
)}
{/* Email Form */}
<form onSubmit={handleEmailLogin} className="space-y-4">
<div className="space-y-2">
<Label htmlFor="email">Email</Label>
<Input
id="email"
type="email"
placeholder="[email protected]"
value={email}
onChange={(e) => {
setEmail(e.target.value);
setError('');
}}
required
disabled={anyLoading}
/>
</div>
<div className="space-y-2">
<Label htmlFor="password">Password</Label>
<Input
id="password"
type="password"
placeholder="••••••••"
value={password}
onChange={(e) => {
setPassword(e.target.value);
setError('');
}}
required
disabled={anyLoading}
/>
</div>
<Button type="submit" className="w-full" disabled={anyLoading}>
{isLoading && <Loader2 className="h-4 w-4 mr-2 animate-spin" />}
Sign in
</Button>
</form>
<p className="text-center text-sm text-muted-foreground mt-6">
Don&apos;t have an account?{' '}
<Link href={registerHref} className="text-primary hover:underline">
Sign up
</Link>
</p>
</CardContent>
</Card>
);
}
export function LoginFormSkeleton() {
return (
<Card>
<CardHeader className="text-center">
<CardTitle>Welcome back</CardTitle>
<CardDescription>Sign in to your account to continue</CardDescription>
</CardHeader>
<CardContent className="space-y-4">
<div className="h-10 bg-muted animate-pulse rounded-md" />
<div className="h-10 bg-muted animate-pulse rounded-md" />
<div className="h-10 bg-primary/20 animate-pulse rounded-md" />
</CardContent>
</Card>
);
}
export function LoginForm({ googleEnabled, githubEnabled }: LoginFormInnerProps) {
return (
<Suspense fallback={<LoginFormSkeleton />}>
<LoginFormInner googleEnabled={googleEnabled} githubEnabled={githubEnabled} />
</Suspense>
);
}